WIP: Improve AliBuild typing and linter strictness #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singiamtel
commented
Nov 12, 2024
| @@ -233,7 +218,7 @@ def fetch_symlinks(self, spec): | |||
| os.path.join(self.workdir, links_path, linkname)) | |||
|
|
|||
| def upload_symlinks_and_tarball(self, spec): | |||
| pass | |||
| dieOnError(True, "HTTP backend does not support uploading directly") | |||
There was a problem hiding this comment.
Is this change correct? The tests seem to suggest that it should fail silently, instead of crashing like how the CVMFS backend fails
singiamtel
force-pushed
the
improve_typing
branch
from
70c9385
to
2320045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently trying to type the codebase as much as possible, and use a stronger mypy filter.
Not ready to merge yet, just want to get the tests running