-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete implementation for Issue #28: Context sensitive help #56
Conversation
…ing started is collapsed
…is a delay to return to the saved state. Rather have the panel come in late, than disappear late.
Thanks for putting this together into one PR. Cookies I don't think the colapsable section with the cookie is a good idea. If people don't want to read it they can just as easily scroll down, removing the need for an extra library and possibly having to worry about cookie compliance within the EU. Tool-Tips I do like the tool-tips. Will just need to get around to adding the missing ones (I am happy to merge without this though and add them later). Withdrawl stratagies This is still a huge section - made worse by the modal being quite thin. Having said that, I don't have any better ideas. Thanks again for this. |
Ok, I'll resubmit without the remembering collapsed state. FYI, in the final pull request (64da1be), I moved to local storage instead of cookies in case it's just cookies you're worried about. For withdrawal strategies, I can do a collapsing accordion. Please don't get rid of bootstrap! :D |
Replaced by PR #57 . Also note that accordion is a Bootstrap 4 feature, so not available on current (3.1) version. |
Single PR to implement all described changes in issue #28
Replaces PR #52 .