Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the - character in the field names #229

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Support the - character in the field names #229

merged 1 commit into from
Oct 30, 2024

Conversation

alirezanet
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #219

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented Oct 30, 2024

PR Summary

  • Update to Tokenization Logic
    The modifications in Lexer.cs now allow hyphens (-) within field names. Previously, these characters caused issues during the tokenization process. This update improves our ability to interpret and process a greater variety of input data.

  • Expanded Test Coverage
    A new test file named Issue219Tests.cs has been added to the system. This file includes specific test cases designed to check that field names containing hyphens are correctly analyzed and interpreted without causing errors. This addition enhances our verification process, ensuring our changes work as intended and increase system's reliability.

@alirezanet alirezanet merged commit e8fc334 into master Oct 30, 2024
2 checks passed
@alirezanet alirezanet deleted the Issue219 branch October 31, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the - character in the field names
1 participant