Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp2040_hal 2.2.1 #978

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

JeremyGrosser
Copy link
Contributor

No description provided.

@JeremyGrosser JeremyGrosser force-pushed the stable-1.2.1 branch 2 times, most recently from fb5a797 to bbb1230 Compare January 27, 2024 23:33
@JeremyGrosser
Copy link
Contributor Author

I don't understand why the CI runs are still failing. It looks like it's trying to use gnat_native when this crate can only be built with gnat_arm_elf, which is listed in the dependencies.

@mosteo
Copy link
Member

mosteo commented Jan 29, 2024

This is likely related to alire-project/alire#1533. Sorry for the trouble, I'll take a look ASAP.

@Fabien-Chouteau
Copy link
Member

I can see a warning during the build of tests:

aunit-memory.adb:35:06: warning: renamed predefined unit is an obsolescent feature (RM J.1) [-gnatwj]

I don't know if that's the problem.

@mosteo
Copy link
Member

mosteo commented Jan 29, 2024

I can reproduce this problem locally, working on the fix.

@mosteo
Copy link
Member

mosteo commented Jan 29, 2024

There are two issues here: one is some mixing of github actions caches, which was causing the apparent mixing of tools. I'm working on that.

The other one is the one pointed by Fabien, which seems legit, see e.g. this run: https://github.com/alire-project/alire-index/actions/runs/7681838264/job/20986832061?pr=978#step:6:825

@JeremyGrosser JeremyGrosser changed the title rp2040_hal 2.2.0 rp2040_hal 2.2.1 Jan 31, 2024
@Fabien-Chouteau
Copy link
Member

My bad, the warning is the issue here [1]. The problem is that the check script is trying to run the test, which is an ARM Cortex-M application for the RP2040.

The scripts assumes that the tests are native applications and that alr run should work.

[1] Aunit is rightfully in not compiled with warnings as error.

@mosteo
Copy link
Member

mosteo commented Feb 8, 2024

So, IIUC, these tests are not intended for execution here, and this release can be merged?

@JeremyGrosser
Copy link
Contributor Author

Correct, these tests can only run on an RP2040. I do think there is value in compiling the tests as a part of CI, but we don't have a good simulator for running them outside of real hardware.

This release can be merged, imo.

@mosteo
Copy link
Member

mosteo commented Feb 8, 2024

Alright, then. After 2.0 the CI script can be updated to rely only on alr test, and that should get rid of the issue.

@mosteo mosteo merged commit 9f5c7b9 into alire-project:stable-1.2.1 Feb 8, 2024
3 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants