-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working version of sample code #135
base: master
Are you sure you want to change the base?
Conversation
What's the difference now between |
@isaachinman I renamed it “simple” since it is React Native boilerplate with the simplest possible implementation of the share extension. I thought, if we add more complex demos in the future, we can use descriptive names rather than SampleN. |
Hi @AndrewHenderson , I just downloaded your pull request, but it doesn't work as expected, although it works, it doesn't behave like the example in the documentation Here is your simple example running in my phone (Xiaomi A2, Android 9): I modified the modal-box properties to start from bottom and specifying a height but I always have the same result... I can't see the backdrop and is always full screen... Is it working properly for you? Best regards. |
Hi, finally I made it work. I noticed that you changed the Modal component from react-native-modalbox to the native one in react-native. After changing back to react-native-modalbox and adding the property |
Another change I had to make for a fresh RN project was in
|
Created a working version of the sample code.
Android works out of the box.
iOS still requires the necessary additional steps to set up.