Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add null pointer check for gRPC stream client span #287

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: add null pointer check for gRPC stream client span #287

merged 2 commits into from
Jan 14, 2025
+165 −10

Conversation

tang95
Copy link
Contributor

@tang95 tang95 commented Jan 13, 2025

When span := trace.SpanFromContext(ctx) returns a noopSpan, gctx might be nil, leading to a nil pointer error.

@tang95 tang95 mentioned this pull request Jan 13, 2025
Closed
@123liuziming 123liuziming merged commit 940ec10 into alibaba:main Jan 14, 2025
9 checks passed
@123liuziming
Copy link
Collaborator

@tang95 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y1yang0 y1yang0 y1yang0 left review comments

@123liuziming 123liuziming 123liuziming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tang95 @123liuziming @y1yang0