Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #269

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Update Makefile #269

merged 3 commits into from
Jan 7, 2025

Conversation

NameHaibinZhang
Copy link
Collaborator

update makefile version

update makefile version
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.86%. Comparing base (753a609) to head (e12239d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   80.02%   82.86%   +2.84%     
==========================================
  Files          23       24       +1     
  Lines         976     1033      +57     
==========================================
+ Hits          781      856      +75     
+ Misses        156      144      -12     
+ Partials       39       33       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
@chaneytech
Copy link
Contributor

For the packager, it should be clear which version to package.
When running make, maybe a parameter can be added to specify the packaging version? If the parameter is not provided, the default value should be taken from the latest Git tag, and the user should be prompted with the version being packaged to avoid unintentional packaging with an incorrect version.

@y1yang0
Copy link
Member

y1yang0 commented Dec 27, 2024

For the packager, it should be clear which version to package. When running make, maybe a parameter can be added to specify the packaging version? If the parameter is not provided, the default value should be taken from the latest Git tag, and the user should be prompted with the version being packaged to avoid unintentional packaging with an incorrect version.

+1

@123liuziming 123liuziming merged commit 146ca84 into main Jan 7, 2025
9 checks passed
@y1yang0 y1yang0 deleted the NameHaibinZhang-patch-1 branch January 7, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants