Fix: Enhance default interface detection logic #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- Updated 'LookupDefaultIfaceName' to support additional naming conventions: - Added support for interfaces like 'ens[0-9]+.*' and 'eth[0-9]+'.
vvhuang-ll
force-pushed
the
fix/default-interface-detection
branch
from
90ad22e to
80d4412
Compare
|
Hi, thank you for your contribution! LGTM, I'll run test first, it will get merged when all tests passed. |
Lyt99
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Related Issue:
Fixes the error: 'cannot lookup default host interface, please manually specify it via --calico-host-interface'.
#322
Test plan:
"