Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis wrapper support lazy init and database options #1602

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

johnlanni
Copy link
Collaborator

Ⅰ. Describe what this PR did

  1. Supports lazy initialization to avoid situations where the service is not ready during initialization.
  2. Supports setting the database to connect to during initialization.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni changed the title redis wrapper support delay init and database options redis wrapper support lazy init and database options Dec 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.50%. Comparing base (ef31e09) to head (2dc1592).
Report is 234 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
+ Coverage   35.91%   43.50%   +7.59%     
==========================================
  Files          69       76       +7     
  Lines       11576    12325     +749     
==========================================
+ Hits         4157     5362    +1205     
+ Misses       7104     6627     -477     
- Partials      315      336      +21     

see 69 files with indirect coverage changes

@johnlanni johnlanni merged commit 748bcb0 into alibaba:main Dec 19, 2024
13 checks passed
yunmaoQu pushed a commit to yunmaoQu/higress that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants