Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the overall log output #1549

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Nov 27, 2024

Ⅰ. Describe what this PR did

convenient for troubleshooting

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.52%. Comparing base (ef31e09) to head (25299b4).
Report is 209 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/ingressv1/controller.go 0.00% 10 Missing ⚠️
pkg/ingress/config/ingress_config.go 0.00% 8 Missing ⚠️
pkg/cert/certmgr.go 0.00% 1 Missing ⚠️
pkg/ingress/config/kingress_config.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   35.91%   43.52%   +7.61%     
==========================================
  Files          69       76       +7     
  Lines       11576    12325     +749     
==========================================
+ Hits         4157     5364    +1207     
+ Misses       7104     6626     -478     
- Partials      315      335      +20     
Files with missing lines Coverage Δ
pkg/bootstrap/server.go 58.20% <ø> (-0.19%) ⬇️
pkg/cmd/server.go 85.88% <ø> (ø)
pkg/ingress/kube/ingress/status.go 14.51% <ø> (+0.45%) ⬆️
pkg/ingress/kube/ingressv1/status.go 0.00% <ø> (ø)
pkg/ingress/kube/kingress/status.go 12.30% <ø> (+0.18%) ⬆️
pkg/cert/certmgr.go 0.00% <0.00%> (ø)
pkg/ingress/config/kingress_config.go 16.70% <0.00%> (-0.27%) ⬇️
pkg/ingress/config/ingress_config.go 12.94% <0.00%> (-0.93%) ⬇️
pkg/ingress/kube/ingressv1/controller.go 5.28% <0.00%> (+0.06%) ⬆️

... and 60 files with indirect coverage changes

@johnlanni johnlanni changed the title optimize resouces convert log Optimize the overall log output Nov 27, 2024
@johnlanni johnlanni merged commit ca7458c into alibaba:main Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants