Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复bug: NodeSelectorSlot只会记录初次调用记录 #3498

Open
wants to merge 4 commits into
base: 1.8
Choose a base branch
from

Conversation

lookingatstarts
Copy link

Describe what this PR does / why we need it

NodeSelectorSlot只会在创建Node时候记录资源的调用关系,这样就只会记录初次调用关系。
eg : A B C三个资源
ContextUtil.enter("invoice-tree");
// 第一次调用
Entry a = SphU.entry("A");
Entry b = SphU.entry("B");
Entry c = SphU.entry("C");
c.exit();
b.exit();
a.exit();
// 第二次调用
a = SphU.entry("A");
Entry d = SphU.entry("D");
d.exit();
a.exit();
仅仅会记录 A -> B -> C 调用关系,, 不会记录 A->D调用关系

Does this pull request fix one issue?

Describe how you did it

将NodeSelectorSlot记录调用的代码移出外围执行

Describe how to verify it

CtEntryTest有相关验证代码

Special notes for reviews

…invocation-tree' into fixbug/node-selector-slot-build-invocation-tree

# Conflicts:
#	sentinel-core/src/test/java/com/alibaba/csp/sentinel/CtEntryTest.java
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants