fix(analytical): Fix Louvain algorithm's stop condition #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage ? 57.42%
=======================================
Files ? 126
Lines ? 13280
Branches ? 0
=======================================
Hits ? 7626
Misses ? 5654
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
|
@songqing Could you please merge main to fix the CI issue? |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When using Louvain algorithm, I found a question with its stop condition, the Louvain algotithm's quality may be 0, 0.85, 0.80, I want to stop the iterations at 0.80 as the quality has started to decrease, but the current stop condition can't do that.
Besides, the change is consistent with NetworkX's implementation
Related issue number
Fixes