-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(interactive): Introduce call_proc
as a new physical operator and implement it
#4288
Conversation
…ify-call-proc-op Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
This comment was marked as resolved.
This comment was marked as resolved.
call_proc
as a new physical operator and implement it
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
const physical::ProcedureCall& opr, | ||
const ReadTransaction& txn, | ||
Context&& ctx) { | ||
auto& query = opr.query(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we fetch the procedure's handler here?
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
=======================================
Coverage 36.96% 36.96%
=======================================
Files 126 126
Lines 13235 13235
=======================================
Hits 4892 4892
Misses 8343 8343 Continue to review full report in Codecov by Sentry.
|
Currently have too kinds graph queries. One is adhoc query, the other is
call_proc
query. We provide two different route and APIs for these two kind of queries, but it is possible to mergecall_proc
query into adhoc query, as an operator.In this PR, we Introduce a
CALL_PROCEDURE
operator intoPhysicalPlan
proto. So, we could remove the/v1/graph/{id}/query
from compiler side. However, we still need the API in server side, for SDK to use.TODO
procedure_call.cc
, including get app_base, and get session. Ideally, we shoud not only involve interfaces of ReadTransaction. -> Negativeprocedure_call.cc
.User now could embed the
call_proc
in a cypher query, for examplewhere
k_neighbors
is a builtin procedure.Fixes #4278