fix(interactive): Fix Logging Errors in Gremlin Server #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
approved these changes
Sep 29, 2024
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4275 +/- ##
=======================================
Coverage ? 34.33%
=======================================
Files ? 126
Lines ? 13235
Branches ? 0
=======================================
Hits ? 4544
Misses ? 8691
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
BingqingLyu
approved these changes
Sep 30, 2024
shirly121
added a commit
to shirly121/GraphScope
that referenced
this pull request
Oct 12, 2024
<!-- Thanks for your contribution! please review https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before opening an issue. --> ## What do these changes do? Due to the PR alibaba#4255 , the Gremlin logs can not be printed properly. This PR fixes the issue using `Logback`. <!-- Please give a short brief about these changes. --> ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Due to the PR #4255 , the Gremlin logs can not be printed properly. This PR fixes the issue using
Logback.Related issue number
Fixes