Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Add Unit Tests for Graph Optimizer in Concurrent Scenario #4274

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Sep 29, 2024

What do these changes do?

  1. Add close() interface in GraphOptimizer to shutdown CleanScheduler (used to clean memory occupation by CBO optimizer periodically) when compiler service stops.
  2. Add ConcurrentBITest to run BI Tests in parallel, to verify the optimizer's functionality in concurrent cases.

Related issue number

Fixes

@shirly121 shirly121 changed the title fix(interactive): Add Unit Tests for Graph Optimizer in Concurrent Use Cases fix(interactive): Add Unit Tests for Graph Optimizer in Concurrent Scenario Sep 29, 2024
Copy link
Contributor

github-actions bot commented Sep 29, 2024

Please check the preview of the documentation changes at
https://624f7ca1.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c3b589d). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4274   +/-   ##
=======================================
  Coverage        ?   34.33%           
=======================================
  Files           ?      126           
  Lines           ?    13235           
  Branches        ?        0           
=======================================
  Hits            ?     4544           
  Misses          ?     8691           
  Partials        ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b589d...8301b71. Read the comment docs.

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit 542cb16 into alibaba:main Oct 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants