Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add view op dynamic shape propagate #1303

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

Yancey1989
Copy link
Collaborator

No description provided.

@Yancey1989 Yancey1989 requested a review from eedalong June 25, 2024 07:49
Copy link
Collaborator

@eedalong eedalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

auto dense_attr = const_op.getValue().dyn_cast<mlir::DenseElementsAttr>();
int64_t value = (*dense_attr.getValues<APInt>().begin()).getSExtValue();
auto dense_attr = constOp.getValue().dyn_cast<mlir::DenseElementsAttr>();
int64_t value = dense_attr.getValues<int64_t>()[0];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to handle other dtype Const like fp16 const later

@Yancey1989 Yancey1989 merged commit 72eec1c into main Jun 28, 2024
11 checks passed
@Yancey1989 Yancey1989 deleted the view_op_shape_propagate branch June 28, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants