Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shape_propagate for more ops #1302

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

eedalong
Copy link
Collaborator

@eedalong eedalong commented Jun 13, 2024

Support shape_propagate for

  • reduce
  • scatter
  • transpose
  • gather
  • dynamic_gather
  • tensor::DimOp

@eedalong eedalong force-pushed the shape_propogate branch 3 times, most recently from 048c3a8 to 9cd90c4 Compare June 14, 2024 08:21
@eedalong eedalong changed the title [WIP] Support shape_propagate for more ops Support shape_propagate for more ops Jun 14, 2024
@eedalong eedalong requested a review from Yancey1989 June 14, 2024 08:24
Yancey1989
Yancey1989 previously approved these changes Jun 17, 2024
Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with tiny comment

};
// Iterate over the propagation functions and apply each one
int idx = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused var?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@eedalong eedalong merged commit 4d35390 into alibaba:main Jun 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants