Optimize input-output alias #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedalong
force-pushed
the
alias_v2
branch
4 times, most recently
from
de0cd0b
to
7df7ebd
Compare
Yancey1989
reviewed
May 17, 2024
| } | ||
| }; | ||
|
|
||
| struct DiscArgsMutationExpandPass |
There was a problem hiding this comment.
It seems only a lhlo op rewriter, can we keep it in the LhloOpRewriter Pass? Let's use a unique pass only if much more related to op conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key is to expand
args_mutationop before GPU code-gen.