Support mhlo.custom_call op processing #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedalong
force-pushed
the
support_mhlo_custom_call
branch
6 times, most recently
from
c874bd7
to
c49104e
Compare
eedalong
changed the title
Yancey1989
reviewed
Mar 1, 2024
| } | ||
| } | ||
|
|
||
| if (!input_placements.empty()) { |
There was a problem hiding this comment.
why erase the back char?
There was a problem hiding this comment.
why erase the back char?
d,d,d, ---> d,d,d, remove the last ','
| hloOp->setAttr("device", rewriter.getStringAttr("x")); | ||
| hloOp->setAttr("input_layouts", rewriter.getStringAttr("*")); | ||
| hloOp->setAttr("output_layouts", rewriter.getStringAttr("*")); | ||
| hloOp->setAttr("expected_input_layouts", rewriter.getStringAttr("*")); |
There was a problem hiding this comment.
input/output layouts should have the same operand number as input/output.
| auto newCustomAttrs = DictionaryAttr::get(hloOp->getContext(), newAttrs); | ||
| hloOp->setAttr("custom_attrs", newCustomAttrs); | ||
|
|
||
| if (hloOp->getNumResults() == 1 && |
There was a problem hiding this comment.
how do we deal with two results operand of tuple<>, Value ? Maybe we can return a failure message If we don't want to deal with this situation.
eedalong
force-pushed
the
support_mhlo_custom_call
branch
2 times, most recently
from
9fe8d0d
to
a68bb67
Compare
eedalong
force-pushed
the
support_mhlo_custom_call
branch
from
a68bb67
to
2d5c87d
Compare
Yancey1989
approved these changes
Mar 4, 2024
| std::string input_placements, output_placements; | ||
| std::string input_layouts, output_layouts; | ||
| for (int i = 0; i < operands.size(); i++) { | ||
| input_placements += "d,"; |
There was a problem hiding this comment.
maybe absl::StrAppend can achieve better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We convert
mhlo.custom_calltomhlo_disc.custom_call_v2and do tuple expansion during this conversion.