Add pass to process input and output alias hint info #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedalong
force-pushed
the
support_input_output_alias
branch
7 times, most recently
from
c1f44bb
to
df62261
Compare
eedalong
changed the title
eedalong
force-pushed
the
support_input_output_alias
branch
4 times, most recently
from
1a7294b
to
d967f6d
Compare
eedalong
force-pushed
the
support_input_output_alias
branch
5 times, most recently
from
2bb882f
to
ba0e392
Compare
Yancey1989
reviewed
Jan 5, 2024
tao_compiler/mlir/disc/BUILD
Outdated
| ":pass_details", | ||
| ":placement_utils", | ||
| ":rng_uniform_custom_call", | ||
| ":topk_custom_call", |
There was a problem hiding this comment.
please polish the dependencies, this target do not need qconv_custom_call at least.
eedalong
force-pushed
the
support_input_output_alias
branch
2 times, most recently
from
0ca06f4
to
7560544
Compare
eedalong
changed the title
eedalong
force-pushed
the
support_input_output_alias
branch
5 times, most recently
from
d95d788
to
c534ad5
Compare
eedalong
force-pushed
the
support_input_output_alias
branch
from
c534ad5
to
657f6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, we provide a mechanism to do memory buffer reuse optimization between module inputs and outputs. Frontend of DISC needs to provide information as module attribute in the form of
input_output_alias_paramsandinput_output_alias_outputs. For example, if you want to reuse the 3rd output tensor and 14th input tensor, 4th output tensor and 2nd input tensor of main module function, you need to provide these two attributes like:DISC will parse this information and try to do buffer reuse.
It should be noted that DISC's handling of input_output_alias information adopts a try-best strategy, which means that it does not guarantee the successful execution of all input-output aliases, but this does not affect the correctness of end-to-end execution. And this pr has no side-effect for other passes.