Refine colreduction fusion strategy of kStitch. #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuxiafei
reviewed
Sep 20, 2023
tao_compiler/mlir/disc/transforms/lhlo_legalize_roots_to_loops.cc
Outdated
Show resolved
Hide resolved
qiuxiafei
previously approved these changes
Sep 21, 2023
Yancey1989
reviewed
Sep 22, 2023
There was a problem hiding this comment.
why remove the pytorch pre version CI task?
There was a problem hiding this comment.
The version of PyTorch of pre CI tasks is outdated and the task will fail, and the available versions are always changing.
| @@ -1478,13 +1478,27 @@ bool BaseGpuFusionStrategy::tryFuse(ShapeAnalysis& shapeAnalysis, | |||
| bool has_row_reduction = llvm::any_of(target.getOpList(), [](Operation* op) { | |||
| return isRank2RowReduction(op); | |||
| }); | |||
| bool has_col_reduciton = llvm::any_of(target.getOpList(), [](Operation* op) { | |||
| bool has_col_reduction = llvm::any_of(target.getOpList(), [](Operation* op) { | |||
There was a problem hiding this comment.
maybe has_rank2_col_reduction is more exactly.
| return false; | ||
| } | ||
|
|
||
| if (has_col_reduction) { |
There was a problem hiding this comment.
a mirror concern, does disc-fusion pass fused col-reduction ops with different shapes?
There was a problem hiding this comment.
A shape constraint is also set in initFusionPattern later, here I will delete the same shape constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add more strict fusion rule for fusionType
kColReduction: guarantee that the OPs to be fused are both Rank2ColReduction and have same shapes.