-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add data indexing API #1255
base: master
Are you sure you want to change the base?
Conversation
lib/common/bucket/dataIndex.ts
Outdated
MetaQuery: { | ||
NextToken: queryParam.nextToken, | ||
MaxResults: queryParam.maxResults, | ||
Query: JSON.stringify(queryParam.query), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里直接转成JSON字符串了,里面的key不需要处理成大写吗
test/browser/browser.test.js
Outdated
@@ -2509,4 +2510,26 @@ describe('browser', () => { | |||
} | |||
}); | |||
}); | |||
|
|||
// oss server 不支持跨域 大概要到9月30号才上生产支持 跨域,后端是:云仁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在应该可以了,这里的case加一下,要保证所有的参数都有设置一下,保证覆盖率
test/node/bucket.test.js
Outdated
it('doMetaQuery()', async () => { | ||
try { | ||
const queryParam = { | ||
query: { operation: 'and', subQueries: [{ Field: 'Size', Value: '1048576', Operation: 'lt' }] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
参数设置全一些,都覆盖一下吧,参考一下文档示例
test/node/bucket.test.js
Outdated
it('doMetaQuery() Aggregations', async () => { | ||
try { | ||
const queryParam = { | ||
query: { operation: 'and', subQueries: [{ Field: 'Size', Value: '1048576', Operation: 'lt' }] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
参数设置全一些,subQueries类型这里对不上,改一下
No description provided.