-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named tuple support #331
Open
tristanmenzel
wants to merge
8
commits into
main
Choose a base branch
from
feat/named-tuples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Named tuple support #331
+12,123
−5,497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achidlow
force-pushed
the
feat/named-tuples
branch
from
October 22, 2024 08:57
fddc245
to
13bb575
Compare
… the same for structs) - introduce pytypes.TupleLikeType that captures both native and ARC4Tuples - make a NamedTupleType subclass of TupleType that exposes a `fields` property which is easier to create & consume - use NamedTuple for pre-compiled data structures - correct implicit arc4 conversion to use iterate_static, which also ensure single evaluation - introduce pytype for NamedTupleBaseType - this is somewhat of a lie, since typing.NamedTuple is not actually part of MRO at runtime due to Python magic, but it's a good lie because it allows resolving expression and type builders for NamedTuple without any hackery - fixing some error messages to start with lower case - expose concrete types on WType and PyType classes, this simplifies some things and Sequence/Mapping was mostly used as shorthand - add some negative tests for NamedTuple scenarios - general refactoring of new NamedTuple feature
achidlow
force-pushed
the
feat/named-tuples
branch
from
October 22, 2024 09:08
13bb575
to
8a9d495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes