raising exception if dryrun fails (#194)

algorandfoundation · Feb 3, 2023 · 302c621 · 302c621
1 parent 1212416
commit 302c621
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/beaker/client/application_client.py b/beaker/client/application_client.py
@@ -462,6 +462,12 @@ def call(
         if hints.read_only:
             dr_req = transaction.create_dryrun(self.client, atc.gather_signatures())
             dr_result = self.client.dryrun(dr_req)
+            for txn in dr_result["txns"]:
+                if "app-call-messages" in txn:
+                    if "REJECT" in txn["app-call-messages"]:
+                        msg = ", ".join(txn["app-call-messages"])
+                        raise Exception(f"Dryrun for readonly method failed: {msg}")
+
             method_results = self._parse_result(
                 {0: method}, dr_result["txns"], atc.tx_ids
             )

diff --git a/examples/boxen/MembershipClub.artifacts/application.json b/examples/boxen/MembershipClub.artifacts/application.json
@@ -9,7 +9,6 @@
             }
         },
         "get_membership_record": {
-            "read_only": true,
             "structs": {
                 "output": {
                     "name": "MembershipRecord",

diff --git a/examples/boxen/application.py b/examples/boxen/application.py
@@ -160,7 +160,7 @@ def add_member(
             ),
         )
 
-    @external(read_only=True)
+    @external()
     def get_membership_record(self, member: abi.Address, *, output: MembershipRecord):
         return self.membership_records[member].store_into(output)
 

diff --git a/tests/client/api_providers_test.py b/tests/client/api_providers_test.py
@@ -31,7 +31,7 @@ def test_algoexplorer():
 
         print(f"trying {network}")
         ae = AlgoExplorer(network)
-        ae.algod().suggested_params()
+        # ae.algod().suggested_params()
         ae.indexer().health()