-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: improve UX for transaction type arguments (#271)
- Loading branch information
1 parent
a3e1647
commit 3150dea
Showing
26 changed files
with
935 additions
and
457 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
273 changes: 228 additions & 45 deletions
273
src/features/applications/components/application-method-definitions.test.tsx
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| const nfdRegex = /^(.+\.algo)$/ | ||
|
|
||
| export const isNFD = (name: string) => nfdRegex.test(name) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import { createReadOnlyAtomAndTimestamp, readOnlyAtomCache } from '@/features/common/data' | ||
| import { Atom, atom, Getter, Setter } from 'jotai' | ||
| import { Nfd, NfdLookup, NfdResult } from './types' | ||
| import { Address } from '@/features/accounts/data/types' | ||
| import { networkConfig } from '@/features/common/data/algo-client' | ||
|
|
||
| const getReverseLookupNfd = async (_: Getter, set: Setter, address: Address, nfdApiUrl: string): Promise<Nfd | null> => { | ||
| try { | ||
| const response = await fetch(`${nfdApiUrl}/nfd/lookup?address=${address}`, { | ||
| method: 'GET', | ||
| headers: { | ||
| accept: 'application/json', | ||
| }, | ||
| }) | ||
|
|
||
| if (!response.ok) { | ||
| return null | ||
| } | ||
|
|
||
| const body = await response.json() | ||
| const nfd = body[address] as NfdResult | ||
| const nfdResult = { | ||
| name: nfd.name, | ||
| depositAccount: nfd.depositAccount, | ||
| caAlgo: nfd.caAlgo ?? [], | ||
| } satisfies NfdResult | ||
|
|
||
| // Cache the NFD result for forward lookups. Reverse lookups will also use this cache | ||
| set(forwardNfdResultsAtom, (prev) => { | ||
| if (!prev.has(nfdResult.name)) { | ||
| const next = new Map(prev) | ||
| next.set(nfdResult.name, createReadOnlyAtomAndTimestamp(nfdResult)) | ||
| return next | ||
| } | ||
| return prev | ||
| }) | ||
|
|
||
| // Cache all *other* addresses associated with this NFD for reverse lookups | ||
| set(reverseNfdsAtom, (prev) => { | ||
| const next = new Map(prev) | ||
| const addressesToAdd = new Set([nfdResult.depositAccount, ...nfdResult.caAlgo].filter((a) => a !== address)) | ||
| addressesToAdd.forEach((address) => { | ||
| if (!prev.has(address)) { | ||
| next.set(address, createReadOnlyAtomAndTimestamp(nfdResult.name)) | ||
| } | ||
| }) | ||
| return next | ||
| }) | ||
|
|
||
| return nfdResult.name | ||
| } catch (e: unknown) { | ||
| return null | ||
| } | ||
| } | ||
|
|
||
| const getForwardLookupNfdResult = async (_: Getter, set: Setter, nfd: Nfd, nfdApiUrl: string): Promise<NfdResult | null> => { | ||
| try { | ||
| const response = await fetch(`${nfdApiUrl}/nfd/${nfd}?view=tiny`, { | ||
| method: 'GET', | ||
| headers: { | ||
| accept: 'application/json', | ||
| }, | ||
| }) | ||
|
|
||
| if (!response.ok) { | ||
| return null | ||
| } | ||
|
|
||
| const body = (await response.json()) as NfdResult | ||
| const nfdResult = { | ||
| name: body.name, | ||
| depositAccount: body.depositAccount, | ||
| caAlgo: body.caAlgo ?? [], | ||
| } satisfies NfdResult | ||
|
|
||
| // Cache all addresses associated with this NFD for reverse lookups | ||
| set(reverseNfdsAtom, (prev) => { | ||
| const next = new Map(prev) | ||
| const addressesToAdd = new Set([nfdResult.depositAccount, ...nfdResult.caAlgo]) | ||
| addressesToAdd.forEach((address) => { | ||
| if (!prev.has(address)) { | ||
| next.set(address, createReadOnlyAtomAndTimestamp(nfdResult.name)) | ||
| } | ||
| }) | ||
| return next | ||
| }) | ||
|
|
||
| return nfdResult | ||
| } catch (e: unknown) { | ||
| return null | ||
| } | ||
| } | ||
|
|
||
| export const getNfdResultAtom = (nfdLookup: NfdLookup): Atom<Promise<NfdResult | null>> => { | ||
| return atom(async (get) => { | ||
| if (!networkConfig.nfdApiUrl) { | ||
| return null | ||
| } | ||
|
|
||
| if ('nfd' in nfdLookup) { | ||
| return await get(getForwardNfdResultAtom(nfdLookup.nfd, networkConfig.nfdApiUrl, { skipTimestampUpdate: true })) | ||
| } | ||
|
|
||
| const nfd = await get(getReverseNfdAtom(nfdLookup.address, networkConfig.nfdApiUrl, { skipTimestampUpdate: true })) | ||
| if (nfd) { | ||
| return await get(getForwardNfdResultAtom(nfd, networkConfig.nfdApiUrl, { skipTimestampUpdate: true })) | ||
| } | ||
| return null | ||
| }) | ||
| } | ||
|
|
||
| const [forwardNfdResultsAtom, getForwardNfdResultAtom] = readOnlyAtomCache(getForwardLookupNfdResult, (nfd) => nfd) | ||
| const [reverseNfdsAtom, getReverseNfdAtom] = readOnlyAtomCache(getReverseLookupNfd, (address) => address) | ||
| export { forwardNfdResultsAtom, reverseNfdsAtom } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { Address } from '@/features/accounts/data/types' | ||
|
|
||
| export type Nfd = string | ||
|
|
||
| export type ForwardNfdLookup = { | ||
| nfd: Nfd | ||
| } | ||
|
|
||
| export type ReverseNfdLookpup = { | ||
| address: string | ||
| } | ||
|
|
||
| export type NfdLookup = ReverseNfdLookpup | ForwardNfdLookup | ||
| export type NfdResult = { | ||
| name: Nfd | ||
| depositAccount: Address | ||
| caAlgo: Address[] | ||
| } |
Oops, something went wrong.