feat: finalizing arc56 abstraction; consolidating arc56 artifacts; #227
+132,876
−365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickDinh
force-pushed
the
feat/app-client
branch
from
50b464b to
78fb8cd
Compare
aorumbayev
force-pushed
the
feat/arc_56_full
branch
from
3b69f75 to
744f05e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the ARC56 abstraction and consolidates ARC56 artifacts for improved testing across algokit-core crates. It introduces a centralized algokit_test_artifacts crate containing standardized contract artifacts and updates existing test code to use these centralized resources instead of local file paths.
- Centralizes contract artifacts in
algokit_test_artifactscrate with static string access - Updates test code to use centralized artifacts instead of direct file system access
- Adds comprehensive documentation for snapshot testing with insta crate
Reviewed Changes
Copilot reviewed 33 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/book/contributing/contributing_guide.md | Adds documentation for snapshot testing with insta crate |
| crates/algokit_utils/tests/transactions/composer/inner_fee_coverage.rs | Updates to use centralized artifacts from test crate |
| crates/algokit_utils/tests/transactions/composer/application_call.rs | Removes file path dependency, uses centralized artifacts |
| crates/algokit_utils/tests/contracts/sandbox/contract.py | Removes contract source files (moved to artifacts) |
| crates/algokit_utils/tests/contracts/nested/contract.algo.ts | Removes contract source files (moved to artifacts) |
| crates/algokit_utils/tests/contracts/inner_fee/contract.py | Removes contract source files (moved to artifacts) |
| crates/algokit_utils/Cargo.toml | Adds dependency on algokit_test_artifacts crate |
| crates/algokit_test_artifacts/src/lib.rs | Creates centralized artifact library with comprehensive documentation |
neilcampbell
approved these changes
Aug 12, 2025
Updates the ARC56 contract data structures to improve clarity and consistency. Renames `StructFieldType::Simple` to `StructFieldType::Value` to better reflect its purpose. Renames `CallEnum` to `CallOnApplicationComplete` and `CreateEnum` to `CreateOnApplicationComplete` to explicitly express the purpose of the enums. Renames `Global` and `Local` to `StateSchema` and uses the same `StateSchema` struct for both global and local state definitions.
Updates `get_signature` to use the ABI method signature, returning a `Result`. This change improves error handling when retrieving method signatures and ensures consistency with ABI specifications. It also handles cases where multiple methods match a given name by explicitly requiring the ABI signature for disambiguation.
aorumbayev
force-pushed
the
feat/arc_56_full
branch
from
9bb09bd to
18f9f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening against Pat's branch temporarily - will rebase after its merged