Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: further improvements in simulate response v2 parser #3

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Jan 8, 2025

@aorumbayev aorumbayev force-pushed the fix/simulate-response-v2 branch from 89623bb to 59783b9 Compare January 8, 2025 23:19
@aorumbayev aorumbayev force-pushed the fix/simulate-response-v2 branch from 59783b9 to 52ac67d Compare January 8, 2025 23:20
@aorumbayev aorumbayev requested a review from lempira January 8, 2025 23:58
@aorumbayev
Copy link
Collaborator Author

@lempira will test the cd pipeline on a fork more thoroughly tomorrow, its largely reusing the algokit-utils-ts setup.

@aorumbayev
Copy link
Collaborator Author

@lempira @neilcampbell should i change the version back to 0.1.0 given that we will be publishing to a new package and it wouldn't make sense to be consistent with Inc's versioning?

@aorumbayev aorumbayev force-pushed the fix/simulate-response-v2 branch 4 times, most recently from b5be3c4 to 4bcb243 Compare January 9, 2025 00:38
@aorumbayev aorumbayev marked this pull request as ready for review January 9, 2025 11:46
@neilcampbell
Copy link

neilcampbell commented Jan 9, 2025

@lempira @neilcampbell should i change the version back to 0.1.0 given that we will be publishing to a new package and it wouldn't make sense to be consistent with Inc's versioning?

@aorumbayev Inclined to continue on from their version, so that if the other package is deprecated, it's simply a change to the package name to switch over for other potential consumers.

package.json Outdated Show resolved Hide resolved
.github/workflows/prod_release.yaml Show resolved Hide resolved
@aorumbayev
Copy link
Collaborator Author

@lempira @neilcampbell should i change the version back to 0.1.0 given that we will be publishing to a new package and it wouldn't make sense to be consistent with Inc's versioning?

@aorumbayev Inclined to continue on from their version, so that if the other package is deprecated, it's simply a change to the package name to switch over for other potential consumers.

Alright, i pinned the current one to 0.3.0 via manual release here https://github.com/algorandfoundation/algokit-avm-debugger/releases/tag/v0.3.0, the semantic releases will kick off first npm publish as 0.3.1, hence continuing the versioning from original repo (cc @lempira )

@lempira
Copy link
Collaborator

lempira commented Jan 10, 2025

@lempira @neilcampbell should i change the version back to 0.1.0 given that we will be publishing to a new package and it wouldn't make sense to be consistent with Inc's versioning?

@aorumbayev Inclined to continue on from their version, so that if the other package is deprecated, it's simply a change to the package name to switch over for other potential consumers.

Alright, i pinned the current one to 0.3.0 via manual release here https://github.com/algorandfoundation/algokit-avm-debugger/releases/tag/v0.3.0, the semantic releases will kick off first npm publish as 0.3.1, hence continuing the versioning from original repo (cc @lempira )

I like the idea of continuing the version number as well

@aorumbayev aorumbayev force-pushed the fix/simulate-response-v2 branch from 4bcb243 to 0e9ceb0 Compare January 13, 2025 10:24
@aorumbayev aorumbayev merged commit 59a2250 into main Jan 13, 2025
4 checks passed
@aorumbayev aorumbayev deleted the fix/simulate-response-v2 branch January 13, 2025 14:17
aorumbayev added a commit that referenced this pull request Jan 13, 2025
* fix: further improvements in simulate response v2 parser

* ci: adding cd pipeline from algokit utils ts

* ci: setting up cd pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't parse simulate trace file
3 participants