Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Tweaks #6167

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Perf Tweaks #6167

merged 3 commits into from
Nov 11, 2024

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Nov 8, 2024

Summary

Set MaxConnectionsPerIP to 4, ERL should kick in when it hits the backlogCongestionThreshold congestion benchmark.

Test Plan

Existing tests should pass, node should run successfully in functional tests.

@gmalouf gmalouf self-assigned this Nov 8, 2024
@gmalouf gmalouf requested a review from cce November 9, 2024 00:20
@gmalouf gmalouf marked this pull request as ready for review November 9, 2024 00:20
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (eff5fb4) to head (0e9dff2).
Report is 1 commits behind head on experimental-tweaks.

Files with missing lines Patch % Lines
data/txHandler.go 75.00% 0 Missing and 1 partial ⚠️
util/rateLimit.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           experimental-tweaks    #6167      +/-   ##
=======================================================
- Coverage                56.29%   56.26%   -0.03%     
=======================================================
  Files                      494      494              
  Lines                    69958    69960       +2     
=======================================================
- Hits                     39381    39362      -19     
- Misses                   27907    27917      +10     
- Partials                  2670     2681      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -14,18 +14,20 @@
"Nodes": [
{
"Name": "Relay0",
"ConfigJSONOverride": "{\"MaxConnectionsPerIP\":8}",
Copy link
Contributor

@cce cce Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to merge to master, need to also similarly update some perf test recipes like scenario3, scenario1 where there are 5 or 10 nodes per box, here are some (-n is # of nodes and -N is number of instances):

$ grep -E '\-N [0-9]+ \-n [0-9]+' */Makefile | awk '{for (i=1; i<=NF; i++) {if ($i == "-N") N=$(i+1); if ($i == "-n") n=$(i+1);} if (n / N > 1) print $0}'
devnet/Makefile:PARAMS=-w 20 -R 5 -N 5 -n 20 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
network-partition/Makefile:PARAMS=-w 100 -R 8 -N 20 -n 100 --npn-algod-nodes 10 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
scenario1/Makefile:PARAMS=-w 100 -R 8 -N 20 -n 100 --npn-algod-nodes 10 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
scenario2/Makefile:PARAMS=-w 400 -R 20 -N 40 -n 200 --npn-algod-nodes 15 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
scenario3/Makefile:PARAMS=-w 10000 -R 20 -N 100 -n 1000 --npn-algod-nodes 15 --node-template node.json --relay-template relay.json

Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for an experimental branch

@gmalouf gmalouf merged commit cc8dbb7 into experimental-tweaks Nov 11, 2024
19 of 20 checks passed
@gmalouf gmalouf deleted the gm-experimental-tweaks branch November 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants