-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf Tweaks #6167
Perf Tweaks #6167
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental-tweaks #6167 +/- ##
=======================================================
- Coverage 56.29% 56.26% -0.03%
=======================================================
Files 494 494
Lines 69958 69960 +2
=======================================================
- Hits 39381 39362 -19
- Misses 27907 27917 +10
- Partials 2670 2681 +11 ☔ View full report in Codecov by Sentry. |
@@ -14,18 +14,20 @@ | |||
"Nodes": [ | |||
{ | |||
"Name": "Relay0", | |||
"ConfigJSONOverride": "{\"MaxConnectionsPerIP\":8}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to merge to master, need to also similarly update some perf test recipes like scenario3, scenario1 where there are 5 or 10 nodes per box, here are some (-n is # of nodes and -N is number of instances):
$ grep -E '\-N [0-9]+ \-n [0-9]+' */Makefile | awk '{for (i=1; i<=NF; i++) {if ($i == "-N") N=$(i+1); if ($i == "-n") n=$(i+1);} if (n / N > 1) print $0}'
devnet/Makefile:PARAMS=-w 20 -R 5 -N 5 -n 20 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
network-partition/Makefile:PARAMS=-w 100 -R 8 -N 20 -n 100 --npn-algod-nodes 10 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
scenario1/Makefile:PARAMS=-w 100 -R 8 -N 20 -n 100 --npn-algod-nodes 10 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
scenario2/Makefile:PARAMS=-w 400 -R 20 -N 40 -n 200 --npn-algod-nodes 15 --node-template node.json --relay-template relay.json --non-participating-node-template nonPartNode.json
scenario3/Makefile:PARAMS=-w 10000 -R 20 -N 100 -n 1000 --npn-algod-nodes 15 --node-template node.json --relay-template relay.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for an experimental branch
Summary
Set MaxConnectionsPerIP to 4, ERL should kick in when it hits the
backlogCongestionThreshold
congestion benchmark.Test Plan
Existing tests should pass, node should run successfully in functional tests.