Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: add support for developing in OpenSUSE Tumbleweed #6153

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

lamg
Copy link
Contributor

@lamg lamg commented Oct 17, 2024

Summary

Support for building source in OpenSUSE Tumbleweed

Test Plan

Built with my local machine.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.28%. Comparing base (c9000bf) to head (43673fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6153      +/-   ##
==========================================
+ Coverage   56.25%   56.28%   +0.02%     
==========================================
  Files         494      494              
  Lines       69954    69954              
==========================================
+ Hits        39355    39372      +17     
+ Misses      27919    27910       -9     
+ Partials     2680     2672       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

onetechnical
onetechnical previously approved these changes Oct 17, 2024
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here looks straightforward, so I'm okay with it, but I haven't tested it directly.

@onetechnical onetechnical changed the title Adding support for developing in OpenSUSE Tumbleweed Tools: add support for developing in OpenSUSE Tumbleweed Oct 17, 2024
@onetechnical onetechnical self-requested a review October 17, 2024 21:11
@onetechnical
Copy link
Contributor

Pulled back approval because there are some missing build dependencies here - perhaps glibc and gcc? Need to experiment a bit more.

@lamg
Copy link
Contributor Author

lamg commented Oct 18, 2024

Just checked following the README instructions with docker run -it opensuse/tumbleweed bash and now the build works. However I had to manually do zypper install git go awk

@onetechnical
Copy link
Contributor

Re-verified in docker. Thanks!

@gmalouf
Copy link
Contributor

gmalouf commented Oct 21, 2024

Thank you!

@gmalouf gmalouf merged commit e3c8fc9 into algorand:master Oct 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants