Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: exclude self from GetPeers results #6132

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

algorandskiy
Copy link
Contributor

Summary

While running DevNet tests I've noticed a node might emit TxSync request to self that does not make any sense.
Fixed by filtering out node's own peerID from peerstore output.

Note, wsnet implementation is not modified because it cannot reliable identify self from DNS (and possible phonebook.json) input.

Test Plan

TODO

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.22%. Comparing base (619d257) to head (23c611a).

Files with missing lines Patch % Lines
network/p2pNetwork.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6132   +/-   ##
=======================================
  Coverage   56.22%   56.22%           
=======================================
  Files         494      494           
  Lines       69954    69958    +4     
=======================================
+ Hits        39330    39334    +4     
+ Misses      27947    27946    -1     
- Partials     2677     2678    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant