-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update README.md to be more concise #6099
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6099 +/- ##
==========================================
+ Coverage 56.25% 56.29% +0.04%
==========================================
Files 490 490
Lines 69699 69699
==========================================
+ Hits 39206 39237 +31
+ Misses 27825 27804 -21
+ Partials 2668 2658 -10 ☔ View full report in Codecov by Sentry. |
Hi @Pcharlesme , Appreciate the work put in here. We will not be adding/accepting a logo at this time to be included in the project. if you want to strip that content out, we can probably get this PR to be mergeable. |
Also important to flesh out the PR description of notable changes made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with Gary - that external logo is no-goer. Textural changes look OK tho.
@algorandskiy @gmalouf Thanks for your feedback |
@Pcharlesme try rebasing to get latest from master/get build passing. README itself is looking good |
Summary
Styling and formatting updates for the main README.
Test Plan
N/A