Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestP2PMakeHostAddressFilter
listening on "0.0.0.0:0" was not ready for a builder having only a single interface with a public IPv4 so its actual listen address became this interface address. Fixed by ensuring ifAddrs()
return non-empty, all elements are public (failure).TestVotersReloadFromDiskAfterOneStateProofCommitted
to use synchronous commits. Handled extra element in deferred commits queue by draining it beforereloadLedger
- a very first commit gets scheduled there because AddBlock -> AddValidatedBlock -> notifyCommit -> scheduleCommit is still being called, andreloadLedger
does not reset the accountWriting wait group (failure).goal-partkey-commands.sh
fails for no good reason - output has all required strings butif echo "$OUTPIT" | grep -q "$STRING"
fails to handle it as expected. I fixed possible whitespaces and fixed shellcheck. Not sure what else.