Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: flaky tests fixes #6098

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Aug 8, 2024

Summary

  1. TestP2PMakeHostAddressFilter listening on "0.0.0.0:0" was not ready for a builder having only a single interface with a public IPv4 so its actual listen address became this interface address. Fixed by ensuring if Addrs() return non-empty, all elements are public (failure).
  2. Rewrote TestVotersReloadFromDiskAfterOneStateProofCommitted to use synchronous commits. Handled extra element in deferred commits queue by draining it before reloadLedger - a very first commit gets scheduled there because AddBlock -> AddValidatedBlock -> notifyCommit -> scheduleCommit is still being called, and reloadLedger does not reset the accountWriting wait group (failure).
  3. goal-partkey-commands.sh fails for no good reason - output has all required strings but if echo "$OUTPIT" | grep -q "$STRING" fails to handle it as expected. I fixed possible whitespaces and fixed shellcheck. Not sure what else.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (c6a433b) to head (5297b06).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6098      +/-   ##
==========================================
+ Coverage   55.80%   56.26%   +0.46%     
==========================================
  Files         489      489              
  Lines       69691    69691              
==========================================
+ Hits        38888    39214     +326     
+ Misses      28108    27816     -292     
+ Partials     2695     2661      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 23a04c2 into algorand:master Aug 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants