Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix e2e subs goal-partkey-commands #6095

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

algorandskiy
Copy link
Contributor

Summary

goal-partkey-commands was extremely buggy:

  1. Uses non-initialized gcmd and INITIAL_ACCOUNT
  2. Does not check if cmd fails (no set -e)
  3. Part key command output parsing was invalid.
  4. Sometimes it raced with some other test and failed to correctly compare part keys. This was fixed by binding goal cmd to a wallet (the runner creates unique wallets for each test).

Also added TESTFILTER handling to e2e-subs so it can run a single test now (similarly to expect tests).

Test Plan

This is a test fix, passed locally

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.23%. Comparing base (d2c4ca7) to head (76fa7dc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6095      +/-   ##
==========================================
- Coverage   56.26%   56.23%   -0.04%     
==========================================
  Files         489      489              
  Lines       69637    69637              
==========================================
- Hits        39182    39157      -25     
- Misses      27796    27817      +21     
- Partials     2659     2663       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 9924574 into algorand:master Aug 7, 2024
18 checks passed
cce added a commit to cce/go-algorand that referenced this pull request Aug 30, 2024
cce added a commit to cce/go-algorand that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants