Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixes to e2e test logs parsers #6093

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

  1. Fix agreement-log.py to support e2e test output without libgoalFixture.go string prefix
  2. Add topology-extract-ws-e2e.py similar to topology-extract-[ws|p2p].py for e2e test network mapping

Test Plan

These are debugging tools, tested manually on this TestTotalWeightChanges log

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (d2c4ca7) to head (2892bc6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6093   +/-   ##
=======================================
  Coverage   56.26%   56.26%           
=======================================
  Files         489      489           
  Lines       69637    69637           
=======================================
+ Hits        39182    39183    +1     
+ Misses      27796    27795    -1     
  Partials     2659     2659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one suggestion to keep the

@algorandskiy algorandskiy merged commit a0815c1 into algorand:master Aug 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants