Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incentives: cache top online accounts and use when building AbsentParticipationAccounts #6085
base: master
Are you sure you want to change the base?
incentives: cache top online accounts and use when building AbsentParticipationAccounts #6085
Changes from 2 commits
21db44d
e968515
8587b28
38d4b8d
9740ddc
b8b9673
0b7fbad
b2f1130
5242990
0baf81f
be464cf
97d0bcf
55d5068
01b150a
0f954d1
c24e809
c252d95
bb82a97
04c0a84
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jannotti in your earlier version, you were able to use the (ledgercore.AccountData).MicroAlgos value returned from
eval.state.mods.Accts.GetData
here without callingAccountData.WithUpdatedRewards()
because you knew all accounts in mods would be guaranteed to already have their rewards updated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall thinking it through that way, but it seems true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth checking rewardsLevel or anything to make sure they were applied? I imagine all accounts touched should end up having them applied them but maybe there are some that don't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do a little further checking. I think any account considered touched here will also be updated. I think for weird cases like an axfer from A to B, only A is touched (since its algo balance changes when paying fee). Similar stuff can happen with accounts in app calls. Probably/hopefully
eval.state.modifiedAccounts()
are exactly the ones that have truly been touched and will therefore have updated balances.