-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: handle txns in pubsub validator #6070
p2p: handle txns in pubsub validator #6070
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6070 +/- ##
==========================================
- Coverage 56.13% 56.10% -0.03%
==========================================
Files 488 489 +1
Lines 69439 69493 +54
==========================================
+ Hits 38978 38990 +12
- Misses 27813 27839 +26
- Partials 2648 2664 +16 ☔ View full report in Codecov by Sentry. |
78fd790
to
355d62e
Compare
Added synchronous batch verifier to pubsub validator handler. |
Added a |
78ae51b
to
5977cca
Compare
Co-authored-by: Jason Paulos <[email protected]>
Fixed test after the behavior change |
Summary
This is a draft implementation on how txHandler logic would look like if fully implemented in pubsub validator.
It loses batch verification part so could be a large performance drawback.
Tried an alternative approach where pubsub validator always returns
Ignore
and then tx handler callsRelay
. This does not work since pubsub discards the second submission as a duplicate.Test Plan
Extended e2e p2p test to send transactions
Performance
Run scenario1s-p2p: 6781.17 TPS
Resolves #6052