-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulate: resource population #6015
base: master
Are you sure you want to change the base?
Changes from all commits
5ba0a9a
028b8c4
941ba6e
a69091c
d9e77ef
4667647
cbd1d8a
d79780f
e6d59ba
54cd38c
673b03d
ceddaa2
62213a0
f616449
6a4f1ee
0524c3c
73e5b4c
6d8c161
022c565
93dd4e9
3f78752
359b5b0
2229b0a
ec7a36a
351f915
99abd2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3948,6 +3948,10 @@ | |||||
"fix-signers": { | ||||||
"description": "If true, signers for transactions that are missing signatures will be fixed during evaluation.", | ||||||
"type": "boolean" | ||||||
}, | ||||||
"populate-resource-arrays": { | ||||||
"description": "If true, return populated resource arrays for each transaction based on unnamed resources", | ||||||
"type": "boolean" | ||||||
} | ||||||
} | ||||||
}, | ||||||
|
@@ -4265,6 +4269,10 @@ | |||||
}, | ||||||
"unnamed-resources-accessed": { | ||||||
"$ref": "#/definitions/SimulateUnnamedResourcesAccessed" | ||||||
}, | ||||||
"populated-resource-arrays": { | ||||||
"description": "Present if populate-resource-arrays is true in the request. In that case, it will be a map of transaction index in the group to populated resource arrays. There may be moure resource arrays given than transaction in the group, which means more app call transactions would be needed for extra resources.", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"type": "object" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unless there is a very compelling reason, I would recommend against using a map with non-string keys in the response object. It makes JSON encoding much more difficult. I'd instead suggest an array, or (my preference) adding this as a property to individual |
||||||
} | ||||||
} | ||||||
}, | ||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer we say "populate-resources" here. I don't think we need to mention the datatype in the name. (This will also lead to some smaller diffs below).