-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove build deps management #5915
base: master
Are you sure you want to change the base?
Conversation
go run supports running an arbitrary go modules like this: go:generate go run golang.org/x/tools/cmd/[email protected] By using that everywhere that our build wanted to demand a previous install of some program, we don't need any of the complexity around `check_deps.sh`, `install_buildtools.sh` and the like. This PR removes them. There shouldn't be a performance problem because the programs will run out of Go's local module cache. Let's see.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5915 +/- ##
==========================================
- Coverage 55.99% 55.98% -0.02%
==========================================
Files 478 478
Lines 67602 67602
==========================================
- Hits 37855 37845 -10
- Misses 27187 27196 +9
- Partials 2560 2561 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like removal some of the shell scripts but I was nice to have all these deps listed in one place with versions. The install_buildtools.sh
missed versions pinning but it is ok.
Maybe it is possible grepping for go run
and buld such a scripts/buildtools/versions
automatically. Or get them in go.mod somehow?
I think it's probably better to
|
Co-authored-by: ohill <[email protected]>
go run
supports running arbitrary go modules like this:go run golang.org/x/tools/cmd/[email protected]
It downloads and compiles as needed, caching the result. By using that everywhere that our build wanted to demand a previous install of some program, we don't need any of the complexity around
check_deps.sh
,install_buildtools.sh
and the like. This PR removes them and the bespoke version management we were doing withversions
file. Now the versions are explicit in the source/Makefiles.There shouldn't be a performance problem because the programs will run out of Go's local module cache. Let's see.