-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algod: Simulate endpoint stack-change exposure #5440
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5440 +/- ##
==========================================
- Coverage 55.78% 55.77% -0.02%
==========================================
Files 446 446
Lines 63258 63400 +142
==========================================
+ Hits 35291 35362 +71
- Misses 25588 25664 +76
+ Partials 2379 2374 -5
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6b88efd
to
c6244fc
Compare
a737fac
to
c667472
Compare
60f7d3f
to
99d91a4
Compare
99d91a4
to
3dbef39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests, I only have minor comments. The most important is probably what to do about dig
and frame_dig
44c9fbf
to
e02b34c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
10b6b24
to
b2bdb2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to merge and face the onslaught of stack
-> Stack
conflicts in my branch!
Summary
This PR should handle #5014, which exposes execution stack trace to simulation endpoint.
Test Plan