-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate: Allow unnamed foreign resource access #5366
Simulate: Allow unnamed foreign resource access #5366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am taking a last look at this PR, closing to an end. Not trying to stop anything, just asking some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I was concerning while I was reading this PR is inner-call from v9 to v8, which I failed to catch up on a live discussion. By reading thread #5366 (comment) it seems more clear to me that the intention is better suited for pure-post-v8 txn group, if I understood correctly.
a0468d5
sry dude, was trying to get license cla pass through... |
Summary
Allows unnamed resources to be referenced from simulated transaction groups. The amount of unnamed resources is (mostly) limited by the number of additional resources the group could reference, but chooses to omit.
For example, a group with completely full foreign refs won't be able to use any unnamed references, and a group with no foreign refs declared will be able to use the maximum amount.
Still to do:
Sort the REST response arrays to make responses deterministic, for easier testing.Skipped for now, since this may not be necessaryTest Plan
Unit tests added for the logic package and simulation. E2E tests also added for goal and simulation REST API.