Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-algolia): ensure "ts-ignore" is present in the output #1035

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 28, 2022

There's no real way to enforce this, but /** comments get preserved in the output, but // comments don't. This is typescript behaviour that's not well documented, as removeComments isn't even false in https://www.typescriptlang.org/tsconfig/#removeComments

cc @slorber for facebook/docusaurus#8261 (comment)

follow up on #1002

There's no real way to enforce this, but /** comments get preserved in the output, but // comments don't. This is typescript behaviour that's not well documented: microsoft/TypeScript#37144
@Haroenv Haroenv requested review from a team, FabienMotte and sarahdayan and removed request for a team October 28, 2022 09:58
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a14fb6c:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv Haroenv merged commit c8a0f68 into next Oct 28, 2022
@Haroenv Haroenv deleted the fix/ts-types-ignore branch October 28, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants