chore(deps): strict regex for package.json and yarn #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
damcou and
shortcuts
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
commented
Jul 13, 2022
.github/workflows/check.yml
Outdated
| @@ -54,6 +54,11 @@ jobs: | |||
| yarn eslint --ext=json . | |||
| echo 'Use yarn fix:json to fix issues' | |||
|
|
|||
| - name: Validate renovate.json | |||
There was a problem hiding this comment.
The validator takes at least 30 seconds tu run, on each PR, either we cache the renovate file or remove this, wdyt ?
There was a problem hiding this comment.
it's not something that should change regularly, we don't have to validate it imo
There was a problem hiding this comment.
(alternatively, this could be in a if with a git diff on the renovate but maybe it's overkill)
There was a problem hiding this comment.
yep I agree, we already some form of validation with the schema anyway
shortcuts
approved these changes
Jul 13, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
In #532 the regex for
package.mustacheand.yarnrc.ymlare too broad and detect things that don't have versions,this should help renovate to find only real deps.