fix(frontend): hidding logic wasn't working for hierachicalFacets panel #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstantSearch panel permits to implement a
hiddenfunction to determine if the panel should be hidden (doc).It wasn't working for hierarchicalFacets, and a workaround had been done in #146 to try to replicate the logic.
The problem is that when the panel is hidden by this hack, if the selected filters are reset, it's not becoming visible anymore.
Changes
hiddenfunction: the hierarchicalFacets are always present inoptions.results.hierarchicalFacets. But when there are no results matching, thedatafield isnull. Checking the presence ofdatafixes the behaviourHow to test
newArrivalsCategoryattributeMen > Accessories > Gloves. The New Arrivals panel disappearsSFCC-410