feat: added pricebook support for variants and product level records #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbellone
requested changes
Dec 5, 2024
cartridges/int_algolia_sfra/cartridge/static/default/js/algolia/instantsearch-config.js
Show resolved
Hide resolved
| @@ -457,6 +439,10 @@ function enableInstantSearch(config) { | |||
|
|
|||
| item.displayPrice = variantPrice; | |||
| item.calloutMsg = variantCalloutMsg; | |||
|
|
|||
| item.highestPriceBookPrice = selectedVariant.pricebooks && selectedVariant.pricebooks[algoliaData.currencyCode] && selectedVariant.pricebooks[algoliaData.currencyCode].length > 0 ? selectedVariant.pricebooks[algoliaData.currencyCode].reduce((max, pricebook) => { | |||
There was a problem hiding this comment.
This doesn't makes things more clear: a 262 characters line with a ternary check at the end that triggers a function is quite hard to process.
You should break it down.
| @@ -287,9 +287,9 @@ function enableInstantSearch(config) { | |||
| <div class="price"> | |||
| ${isPricingLazyLoad && html`<span class="price-placeholder" data-product-id="${productId}"></span>`} | |||
| ${!isPricingLazyLoad && html` | |||
| ${ (hit.displayPrice < hit.price || (hit.promotionalPrice && hit.promotionalPrice < hit.price)) && html` | |||
| ${ (hit.displayPrice < hit.price || (hit.promotionalPrice && hit.promotionalPrice < hit.price) || (hit.highestPriceBookPrice && hit.highestPriceBookPrice > hit.displayPrice)) && html` | |||
There was a problem hiding this comment.
You've made things more clear with the calculateDisplayPrice function, but you have complexified this part.
It's a good occasion to improve the transformItem function and generate prices ready to be displayed:
- a
strikeoutprice if there is one - a
displayPrice
So the HTML doesn't need such complex logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed
calculateDisplayPricemake things more clear and using common logic for different records models