Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAGE-1084: Multistore Replicas tests #1663

Open
wants to merge 4 commits into
base: release/3.15.0-dev
Choose a base branch
from
Open

MAGE-1084: Multistore Replicas tests #1663

wants to merge 4 commits into from

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Dec 19, 2024 •
edited
Loading

This PR contains:

  • Added tests for Replicas with multi stores/applications context
  • Created a ReplicaAssertionsTrait class which contains all the methods to be used by the ReplicaIndexingTest class AND the newly created MultiStoreReplicaTest class.
  • Updated some methods of the ReplicaAssertionsTrait class to handle store switching
  • Added a test for customer groups replicas

@damcou damcou requested a review from cammonro December 19, 2024 14:24
@damcou damcou self-assigned this Dec 19, 2024
cammonro
cammonro reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! But I suspect something may be off with setUp/tearDown? 🤔

Getting different results depending on execution sequence..
2024-12-21_20-13-35
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammonro cammonro cammonro left review comments

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damcou @cammonro