Fixed FB logging redirecting to 404 due to undefined api version

algoan-archive · Mar 19, 2018 · 0145afb · 0145afb
1 parent 64d3ee2
commit 0145afb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 2.3.1
+
+* Fixed FB logging redirecting to 404 due to undefined api version 
+
 # 2.3.0
 
 * Updated default graph API version to 2.12 @rwky
diff --git a/lib/strategy.js b/lib/strategy.js
@@ -47,7 +47,7 @@ var OAuth2Strategy = require('passport-oauth2')
  */
 function Strategy(options, verify) {
   options = options || {};
-  var graphApiVersion = options.graphApiVersion || this.defaultGraphApiVersion;
+  var graphApiVersion = options.graphApiVersion || Strategy.defaultGraphApiVersion;
   options.authorizationURL = options.authorizationURL || 'https://www.facebook.com/' + graphApiVersion + '/dialog/oauth';
   options.tokenURL = options.tokenURL || 'https://graph.facebook.com/' + graphApiVersion + '/oauth/access_token';
   options.scopeSeparator = options.scopeSeparator || ',';
@@ -61,7 +61,7 @@ function Strategy(options, verify) {
 }
 
 // Set the default API version once
-Strategy.prototype.defaultGraphApiVersion = 'v2.12';
+Strategy.defaultGraphApiVersion = 'v2.12';
 
 
 // Inherit from `OAuth2Strategy`.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "passport-facebook-rwky",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "Facebook authentication strategy for Passport.",
   "keywords": [
     "passport",

diff --git a/test/strategy.profile.test.js b/test/strategy.profile.test.js
@@ -2,7 +2,7 @@
 /* jshint expr: true */
 
 var FacebookStrategy = require('../lib/strategy')
-  , graphApiVersion = FacebookStrategy.prototype.defaultGraphApiVersion;
+  , graphApiVersion = FacebookStrategy.defaultGraphApiVersion;
 
 
 describe('Strategy#userProfile', function() {

diff --git a/test/strategy.test.js b/test/strategy.test.js
@@ -3,7 +3,7 @@
 
 var chai = require('chai')
   , FacebookStrategy = require('../lib/strategy')
-  , graphApiVersion = FacebookStrategy.prototype.defaultGraphApiVersion;
+  , graphApiVersion = FacebookStrategy.defaultGraphApiVersion;
 
 describe('Strategy', function() {