Update the linear-gradient() function to new syntax. Close #73 #77
Conversation
|
@roblevintennis mind taking a peak at this one? |
|
@alexwolfe in terms of staging it or spot checking, I'm not going to have time for a bit .. slammed at work. But the syntax refactor looks correct to me. |
|
No worries I'll take a look
…On Fri, Jul 14, 2017 at 1:33 PM Rob Levin ***@***.***> wrote:
@alexwolfe <https://github.com/alexwolfe> not going to have time for a
bit .. slammed at work
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAY2xb9c-NUSuESWcaUpoCxJN-r3kfz9ks5sN9CggaJpZM4OYYYa>
.
|
|
@alexwolfe I'm in the process of trying to update our app to the buttons-2 branch, and noticed this in our webpack compile (I believe the warning was via autoprefixer). In any event, I changed |
|
Thanks Rob, appreciate it amigo!
…On Mon, Aug 21, 2017 at 12:43 PM, Rob Levin ***@***.***> wrote:
@alexwolfe <https://github.com/alexwolfe> I'm in the process of trying to
update our app to the buttons-2 branch, and noticed this in our webpack
compile (I believe the warning was via autoprefixer). In any event, I
changed to bottom and the warnings went away
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAY2xbcJlW7GeAL7B2flPIuACowuIJxzks5sad3KgaJpZM4OYYYa>
.
|
|
@alexwolfe and fwiw, I'm now spot checking buttons on pages and their rendering as expected (I think) ... this is probably fine to merge |
|
Cool, thanks again man!
…On Mon, Aug 21, 2017 at 3:47 PM, Rob Levin ***@***.***> wrote:
@alexwolfe <https://github.com/alexwolfe> and fwiw, I'm now spot checking
buttons on pages and their rendering as expected (I think) ... this is
probably fine to merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAY2xQs3u8s57mfeGqwJQLS3Qi4kzYGLks5sagkBgaJpZM4OYYYa>
.
|
|
Kinda posting back as I see things lol, sorry, but here's the raised button in the app after changing syntax (using v2 Buttons, but the raised buttons appear to be the same). Here's console CSS (I manually added raised, so ignore the fact that the adjacent invite buttons are flat 😄
I'm not sure which browser has what syntax at this point, but, we use a very conservative autoprefixer: last 5 versions
Explorer >= 10
Firefox >= 17
Chrome >= 31
Safari >= 5
Opera >= 12So I'm not sure how helpful the output is ... in any event, it's compiling with no complaints and rendering |
|
Having the same problem here. Any news? |
|
@gwleuverink sorry, yeah, I just merged this..Alex and I have trouble finding time to maintain. If you don't mind, could you just pull down latest and ensure we didn't break something in a major way? Thanks .. cc / @meteorlxy thanks for PR. If you have a spare moment, your code was merged and I don't have time to verify nothing broke. Thanks in advanced and sorry for the delay! |
|
Hi @roblevintennis. Thanks for your quick reply and making time to adress this. I have been running a fork with this fix in a project since this morning and have not noticed any issues with compiling or the buttons themselves. I will swap the repo on monday to confirm this pr works as well. |
|
@roblevintennis Never mind, finally merged~ |
|
awesome .. thanks @meteorlxy ! |
|
Yep it works perfectly. Tested it today. |
|
great thx for confirmation @gwleuverink cc / @alexwolfe .. are we porting these up to the unicorn-ui version buttons 2 version? I sort of lost track of which branch has "buttons 2" |
Update the linear-gradient() function to new syntax. Issue #73.
BTW, why there is no official package on npm?