Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "width: 100%" to support -block on <button> tag #74

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Add "width: 100%" to support -block on <button> tag #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scss/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
#{$ubtn-namespace}-block,
#{$ubtn-namespace}-stacked {
display: block;
}
width: 100%;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add
box-sizing: border-box;

This will allow the padding and borders to be included in the calculation for 100% preventing the width from exceeding 100% and causing display issues. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

box-sizing: border-box;
is already define in _base.scss , I think it is not necessary to re-define it in the -block class.
what do you think ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes thanks for the reminder 👍 You're good to go, merging.

}