Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for PDOK NL #1634

Merged
merged 5 commits into from
Oct 22, 2023
Merged

adding support for PDOK NL #1634

merged 5 commits into from
Oct 22, 2023

Conversation

opensourceame
Copy link
Contributor

@opensourceame opensourceame commented Sep 19, 2023 •
edited
Loading

This PR adds support for pdok, a new Geocoding service for The Netherlands that replaces Nationaal Georegister.

opensourceame
opensourceame commented Sep 19, 2023
View reviewed changes
.gitignore Outdated
@@ -6,3 +6,4 @@ rdoc/*
Gemfile.lock
api_keys.yml
test/geocoder_test.sqlite
.idea/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.idea is created by RubyMine which is a very popular IDE

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however, everything in this .gitignore file should be specific to the Geocoder gem. To ignore files related to local development, please use your ~/.gitignore_global file.

@opensourceame
Copy link
Contributor Author

@alexreisner the old Nationaal Georegister has been deprecated. I can remove the code from the old platform in this PR or a create a new PR for that. What would you prefer?

@alexreisner
Copy link
Owner

Thanks for this! It looks great. If you can remove that line from .gitignore, I'll merge. And feel free to submit another request for removing the deprecated API.

@opensourceame
Copy link
Contributor Author

Thanks for this! It looks great. If you can remove that line from .gitignore, I'll merge. And feel free to submit another request for removing the deprecated API.

Done @alexreisner 👍

@alexreisner alexreisner merged commit cdb47ee into alexreisner:master Oct 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexreisner alexreisner Awaiting requested review from alexreisner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensourceame @alexreisner