feat: support constructor arguments given as explicit binders #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equilibris
force-pushed
the
feat-11-alt-binders
branch
from
8ef357b to
9b34c8f
Compare
Equilibris
commented
Jun 24, 2024
Qpf/Macro/Data/Replace.lean
Outdated
| def preProcessCtors (view : DataView) : m DataView := do | ||
| let ctors ← view.ctors.mapM fun ctor => do | ||
| let namedArgs ← ctor.binders.getArgs.mapM getBinderNamesAndType | ||
| let flatArgs: Array (TSyntax `term) := (namedArgs.map (fun (ids, ty) => ids.map (fun _ => ⟨ty⟩))).flatten.reverse |
There was a problem hiding this comment.
Make code a bit more succinct
Suggested change
| let flatArgs: Array (TSyntax `term) := (namedArgs.map (fun (ids, ty) => ids.map (fun _ => ⟨ty⟩))).flatten.reverse | |
| let flatArgs : Array Term := | |
| (namedArgs.map (fun (ids, ty) => ids.map (fun _ => ⟨ty⟩))) | |
| |>.flatten.reverse |
alexkeizer
requested changes
Jun 24, 2024
Qpf/Macro/Data.lean
Outdated
Comment on lines
543
to
545
| /- Transforms binders into simple lambda types. -/ | ||
| let view ← dataSyntaxToView modifiers decl | ||
| let view ← preProcessCtors view /- same as >>= -/ |
There was a problem hiding this comment.
Suggested change
| /- Transforms binders into simple lambda types. -/ | |
| let view ← dataSyntaxToView modifiers decl | |
| let view ← preProcessCtors view /- same as >>= -/ | |
| let view ← dataSyntaxToView modifiers decl | |
| let view ← preProcessCtors view -- Transforms binders into arrow types |
Qpf/Macro/Data/Replace.lean
Outdated
Comment on lines
147
to
153
| -- Have a look at how, e.g., def, deals with binders, | ||
| -- this method might already exist look for BinderView | ||
| def getBinderNamesAndType : Syntax → m (Array Syntax × Syntax) | ||
| | .node _ `Lean.Parser.Term.explicitBinder | ||
| #[_, (.node _ `null ids), (.node _ `null #[_, ty]), _, _] => | ||
| pure (ids, ty) | ||
| | _ => Elab.throwUnsupportedSyntax |
There was a problem hiding this comment.
alexkeizer
reviewed
Jun 25, 2024
alexkeizer
changed the title
alexkeizer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11